以上代码的优缺点
优点是比较好理解,简单易操作缺点是违反了设计模式的ocp原则,即对扩展开放,对修改关闭比如我们这时要新增加一个图形种类,我们需要做如下修改,修改的地方比较多 package ocp; import java.awt.image.CropImageFilter; public class Ocp { public static void main(String[] args) { GraphicEditor graphicEditor = new GraphicEditor(); graphicEditor.drawShape(new Rectangle()); graphicEditor.drawShape(new Circle()); graphicEditor.drawShape(new Triangle()); } } class GraphicEditor{ public void drawShape(Shape s){ if(s.m_type == 1){ drawRectangle(s); } else if(s.m_type == 2){ drawCircle(s); } else if(s.m_type == 3){ drawTriangle(s); } } private void drawRectangle(Shape r){ System.out.println("绘制矩形"); } private void drawCircle(Shape r){ System.out.println("绘制圆形"); } private void drawTriangle(Shape r){ System.out.println("绘制三角形"); } } class Shape{ int m_type; } class Rectangle extends Shape{ Rectangle(){ super.m_type = 1; } } class Circle extends Shape{ Circle(){ super.m_type = 2; } } class Triangle extends Shape{ Triangle(){ super.m_type = 3; } }以上代码显示出使用方也修改了代码
改进思路:
把创建的Shape类做成抽象类,并提供一个抽象的draw方法,让子类去实现即可,这样我们有新的图形种类时,只需要让新的图像类继承Shape,并实现draw方法即可,使用方的代码就不需要修改。
package ocp.improve; public class Ocp { public static void main(String[] args) { GraphicEditor graphicEditor = new GraphicEditor(); graphicEditor.drawShape(new Rectangle()); graphicEditor.drawShape(new Circle()); graphicEditor.drawShape(new Triangle()); } } class GraphicEditor{ public void drawShape(Shape s){ s.draw();//直接调用s.draw()就完事了 } } abstract class Shape{ int m_type; public abstract void draw();//抽象方法 } class Rectangle extends Shape{ Rectangle(){ super.m_type = 1; } @Override public void draw() { System.out.println("绘制矩形"); } } class Circle extends Shape{ Circle(){ super.m_type = 2; } @Override public void draw() { System.out.println("绘制圆形"); } } class Triangle extends Shape{ Triangle(){ super.m_type = 3; } @Override public void draw() { System.out.println("绘制三角形"); } }新增一个图形的时候不会修改使用方,只需要扩展一个类即可